Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README.md #98

Merged
merged 1 commit into from
Feb 27, 2023
Merged

docs: update README.md #98

merged 1 commit into from
Feb 27, 2023

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Feb 24, 2023 •
edited
Loading

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

After testing with DellEMC VxRAIL, updating the README.md to note support for both vSAN ReadyNode and DellEMC VxRAIL based architectures.

Note
Additional enhancements could be made to support collecting VxRAIL Manager version and other specific VxRAIL contexts. Please feel free to open issues and pull requests if you'd like to contribute.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

docs: update README.md
b1c231d 
After testing with DellEMC VxRAIL, updating the `README.md` to note support for both vSAN ReadyNode and DellEMC VxRAIL based architectures.

Note: Additional enhancements could be made to support collecting VxRAIL Manager version and other specific VxRAIL contexts. Please feel free to open issues and pull requests if you'd like to contribute.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam added the documentation Documentation label Feb 24, 2023
@tenthirtyam tenthirtyam added this to the v1.1.0 milestone Feb 24, 2023
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 24, 2023 21:19
@tenthirtyam tenthirtyam self-assigned this Feb 24, 2023
GaryJBlake
GaryJBlake approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@GaryJBlake GaryJBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaryJBlake GaryJBlake merged commit 2102ac9 into main Feb 27, 2023
@GaryJBlake GaryJBlake deleted the docs/update-readme branch February 27, 2023 11:52
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GaryJBlake GaryJBlake GaryJBlake approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
documentation Documentation
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tenthirtyam @GaryJBlake